Re: MIOpen package LFS files
Hi Cory,
> On May 7, 2024, at 16:10, Cordell Bloor <cgmb@slerp.xyz> wrote:
>
> Did someone really write three thousand lines of uncommented assembly code, or is this file a disassembly of some other source [9]?
Looking at upstream PRs uploading [10, 11] target at src/kernels/*.inc, these assembly codes are commit directly without any extra information.
So maybe they are disassembled from some internal artifacts?
> I suppose I have the same question about the performance database files. How are they created and how are they maintained?
Likewise, the binary kdb files are maintained in an opaque way [12], the AMD engineer uploaded the binaries without explanation.
Note that ROCm official APT repository provides the kdb .deb files [13], and both MIOpen and PyTorch offers the approaches to install them in addition to MIOpen [14, 15].
It seems that Fedora [16] and Archlinux [17] both use the released tarball to install MIOpen, where the .kdb files are just LFS refs.
So their versions of MIOpen don’t incorporate the binary files [18, 19].
Best,
Xuanteng
>> [1]: https://rocm.docs.amd.com/projects/MIOpen/en/latest/
>> [2]: https://salsa.debian.org/rocm-team/miopen/-/tree/master/src/kernels?ref_type=heads
>> [3]: https://rocm.docs.amd.com/projects/MIOpen/en/develop/conceptual/perfdb.html
>> [4]: https://salsa.debian.org/rocm-team/miopen/-/blob/master/src/binary_cache.cpp?ref_type=heads#L114-129
>> [5]: https://salsa.debian.org/rocm-team/miopen/-/blob/master/CMakeLists.txt?ref_type=heads#L501-521
>> [6]: https://salsa.debian.org/rocm-team/miopen/-/blob/master/src/binary_cache.cpp?ref_type=heads#L162-180
>> [7]: https://salsa.debian.org/rocm-team/miopen/-/blob/master/src/hip/handlehip.cpp?ref_type=heads#L403-413
>> [8]: https://salsa.debian.org/rocm-team/miopen/-/blob/master/src/hip/handlehip.cpp?ref_type=heads#L415-424
>>
> [9]: https://salsa.debian.org/rocm-team/miopen/-/blob/upstream/5.5.1/src/kernels/Conv_Winograd_v14_3_3_fp16dot_stride2_dec.inc?ref_type=tags
[10]: https://github.com/ROCm/MIOpen/pull/2778
[11]: https://github.com/ROCm/MIOpen/pull/1968
[12]: https://github.com/ROCm/MIOpen/pull/2859
[13]: https://repo.radeon.com/rocm/apt/latest/pool/main/m
[14]: https://rocm.docs.amd.com/projects/MIOpen/en/latest/install.html#installing-miopen-kernels-package
[15]: https://github.com/ROCm/pytorch/wiki/Using-MIOpen-kdb-files-with-ROCm-PyTorch-wheels
[16]: https://src.fedoraproject.org/rpms/miopen/blob/rawhide/f/miopen.spec#_44
[17]: https://gitlab.archlinux.org/archlinux/packaging/packages/miopen-hip/-/blob/main/PKGBUILD#L20
[18]: https://archlinux.org/packages/extra/x86_64/miopen-hip/
[19]: https://packages.fedoraproject.org/pkgs/miopen/miopen/fedora-rawhide.html
Reply to: