[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1035835: marked as done (libamdhip64-dev: find_package(hip) fails if CXX language is not enabled)

Your message dated Sun, 11 Jun 2023 18:49:38 +0000
with message-id <E1q8Q8A-00CcYV-1a@fasolo.debian.org>
and subject line Bug#1035835: fixed in rocm-hipamd 5.2.3-9
has caused the Debian Bug report #1035835,
regarding libamdhip64-dev: find_package(hip) fails if CXX language is not enabled
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1035835: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1035835
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: libamdhip64-dev
Version: 5.2.3-8
Severity: normal
X-Debbugs-Cc: cgmb@slerp.xyz

Dear Maintainer,

The libamdhip64-dev package requires the CXX language to be enabled in
order for find_package(hip) to succeed. This is because there is an
unquoted check against the CXX compiler within hip-config.cmake. The
variable for the compiler should be quoted to compare against an empty
string in the case that the compiler variable is undefined (rather than
causing a syntax error).

What was done:

    apt-get -y update
    apt-get -y install build-essential cmake libamdhip64-dev hipcc
    cat << 'EOF' > main.c
    #include <hip/hip_runtime_api.h>
    int main() {
      return 0;
    }
    EOF
    cat << 'EOF' > CMakeLists.txt
    cmake_minimum_required(VERSION 3.16)
    project(example LANGUAGES C)
    find_package(hip REQUIRED)
    add_executable(example main.c)
    target_link_libraries(example PRIVATE hip::host)
    EOF
    cmake -S. -Bbuild

What was seen:

    # cmake -S. -Bbuild
    -- The C compiler identification is GNU 12.2.0
    -- Detecting C compiler ABI info
    -- Detecting C compiler ABI info - done
    -- Check for working C compiler: /usr/bin/cc - skipped
    -- Detecting C compile features
    -- Detecting C compile features - done
    -- Performing Test CMAKE_HAVE_LIBC_PTHREAD
    -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
    -- Found Threads: TRUE
    -- hip::amdhip64 is SHARED_LIBRARY
    CMake Error at /usr/lib/x86_64-linux-gnu/cmake/hip/hip-config.cmake:290 (if):
      if given arguments:
    
        "STREQUAL" "Clang"
    
      Unknown arguments specified
    Call Stack (most recent call first):
      CMakeLists.txt:3 (find_package)
    
    
    -- Configuring incomplete, errors occurred!
    See also "/root/build/CMakeFiles/CMakeOutput.log".


-- System Information:
Debian Release: 12.0
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.1.0-8-amd64 (SMP w/32 CPU threads; PREEMPT)
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: unable to detect

Versions of packages libamdhip64-dev depends on:
ii  libamd-comgr-dev     5.2.3-2
ii  libamdhip64-5        5.2.3-8
ii  libhiprtc-builtins5  5.2.3-8
ii  libhsa-runtime-dev   5.2.3-3

libamdhip64-dev recommends no packages.

libamdhip64-dev suggests no packages.

-- no debconf information

--- End Message ---
--- Begin Message --- 
Source: rocm-hipamd
Source-Version: 5.2.3-9
Done: Cordell Bloor <cgmb@slerp.xyz>

We believe that the bug you reported is fixed in the latest version of
rocm-hipamd, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1035835@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Cordell Bloor <cgmb@slerp.xyz> (supplier of updated rocm-hipamd package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 22 May 2023 18:00:40 -0600
Source: rocm-hipamd
Architecture: source
Version: 5.2.3-9
Distribution: unstable
Urgency: medium
Maintainer: Debian ROCm Team <debian-ai@lists.debian.org>
Changed-By: Cordell Bloor <cgmb@slerp.xyz>
Closes: 1033924 1035834 1035835
Changes:
 rocm-hipamd (5.2.3-9) unstable; urgency=medium
 .
   [ Christian Kastner]
   * Reintroduce the changes we temporarily reverted for bookworm, these being:
     - Build tests again
     - Add rocminfo and libclang-rt-15-dev to Build-Depends
     - Limit Architecture to amd64, arm64, ppc64el
     - Bump Standards-Version to 4.6.2 (no changes needed)
     - Add autopkgtests
 .
   [ Cordell Bloor ]
   * Fix find_package when CXX language not enabled (Closes: #1035835)
   * Fix find_package when hipcc is not installed (Closes: #1035834)
   * Fix hipconfig --check (Closes: #1033924)
   * Cleanup search of multiarch for devicelibs.
   * Fix hipcc on ppc64el.
Checksums-Sha1:
 11ee4e20d4377d7416d6dcd72b9c235466de81c1 3552 rocm-hipamd_5.2.3-9.dsc
 586e81677b882641f3860b012cd0487f02391069 21928 rocm-hipamd_5.2.3-9.debian.tar.xz
 249d8a82082f68bd11ab3bc1dfd3ee5a34b2ea9f 5902 rocm-hipamd_5.2.3-9_source.buildinfo
Checksums-Sha256:
 d88bd4ffc3faa51de4203302e0b1bcd89c60a041b046926890456ccaa431b2e8 3552 rocm-hipamd_5.2.3-9.dsc
 9e20acf38a073da3fac700ca4e9a3567bfc3d56a82d78336c10be9028f39d89c 21928 rocm-hipamd_5.2.3-9.debian.tar.xz
 2bf94f526eee926fb4cabe96ee0ea1f399b4fa70a57dd54c7c67d3d73cc9e37f 5902 rocm-hipamd_5.2.3-9_source.buildinfo
Files:
 2dddde7cf905ff2fc77a0bfd9754488c 3552 devel optional rocm-hipamd_5.2.3-9.dsc
 e6c5b5991bef8770b9cb3aaea523ef99 21928 devel optional rocm-hipamd_5.2.3-9.debian.tar.xz
 cee3119a309d03247c0e8823ec3ae46b 5902 devel optional rocm-hipamd_5.2.3-9_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEQZ9+mkfDq5UZ8bCjOZU6N95Os2sFAmSGCB4ACgkQOZU6N95O
s2uHOA//Z4gIfQCLffDQAeJEAM6i6uADRS+0ctETOmct6JcDQLm1V+0dz7k7082A
T92mV4wfB9YVOGInw+VDcao9pLdnz8sOEaU0JY0kMeZlwv5bCuONZ5bB5PS20RYz
ILEAmfZAAVUyA7hRCh1Pv7fVFHqhEH2Xlli3d35eyDYlJwHVbaBQqPyz+0RsUbdL
GRL+Tccdaa3klYpVBnyLjvmWTT0ub4bl1RGZKGzZvEMaXEhbNsnflHxQGvHPrEK5
g5jI3+Ig9GAJXivihj3fGts77MREFf4Yh6yDGU4ur231Ofqr5rLCG8oV+1DL3bzm
IqZPjzlUn/U5jzwUqWBLDstHbue03Sui8+AshtP8emwEr5SXVIzIyb9UcIHWSu+L
QdHqp3Yn5niFpFoa4AX1r3459CWR1CClKargyAdszqGSWKnsWqSzs039860fDRq+
f1X/xtfX36uLNbRbfjeNFIxEWc1gdneuv5N9aQmq/7hXMk6HeIpduWqJw2h9TIca
71uYGECh3wjvV9B+4UMMe3q5yZYxi1e7k5VmlGe6jz5qhruFpf1OCtJvPuwtx51n
rNEyOsT6smtjv2SjcLXw2sDwzSpLc4DGsDwrP+BOWyLZ4K5zKQERomt7y7uorZCX
nR9Rckx3eta+IDz2g0bsneyUCXW98CaGcpbXLM3hhhOoCSzPSv4=
=sTnQ
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: